Apply suggestions from code review

Co-authored-by: Damir Jelić <poljar@termina.org.uk>
This commit is contained in:
Richard van der Hoff 2023-03-30 15:38:42 +01:00 committed by GitHub
parent 4f3f9c7af8
commit f60c678af8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 6 deletions

View File

@ -2,7 +2,7 @@
#
# It is triggered when a new tag appears that matches
# `matrix-sdk-crypto-js-[0-9]+.*`. This workflow builds the package
# for the binding, run its tests to ensure everything is still
# for the bindings, runs its tests to ensure everything is still
# correct, and publishes the package on NPM and on a newly created
# Github release.

View File

@ -1,14 +1,14 @@
Steps for releasing `matrix-sdk-crypto-js`
==========================================
1. Create a new branch, named `release-matrix-sdk-crypto-js-<version>`
1. Create a new branch, named `release-matrix-sdk-crypto-js-<version>`.
2. Update `CHANGELOG.md`, if necessary.
3. Run `yarn version` to bump the version number and create a tag.
4. Push the branch, but not yet the tag.
5. Create a PR to approve the changes.
6. Once approved:
1. Update the git tag to the new head of the branch, if necessary.
2. push the git tag; doing so triggers the github actions workflow which
builds and publishes to npm, and creates a draft GH release
3. merge the PR
7. Update the release on github and publish
2. Push the git tag; doing so triggers the github actions workflow which
builds and publishes to npm, and creates a draft GH release.
3. Merge the PR.
7. Update the release on github and publish.